Support

Search results for ""

Sorry, no results found. Perhaps you would like to search the documentation?
All Topics
JJ Toothman

Two bugs in Admin Columns Pro v7.0.15

Hello Admin Columns team,

We’re upgrading from Admin Columns Pro 6.4.24 to 7.0.15 on a large WordPress multisite. During verification on our staging environment we identified two reproducible bugs in the v7.0.15 release that are blocking our deployment. Both appear to be small, mechanical mistakes from the v7 refactor, and we’d like to propose the fixes for inclusion in your next release.

Bug 1 — Missing trailing semicolon in acui.css breaks icon font loading on sites with CSS bundling
—————————————————————————————————–

The minified file admin-columns/assets/css/acui.css ends with the rule @layer acui, acui-components (no terminating semicolon). When the file is concatenated with another stylesheet by an edge CSS optimizer (in our case WP VIP’s bundler), the following file’s @font-face rule defining AcMaterialSymbolsOutlined gets parsed as a continuation of the unterminated @layer rule, becomes invalid CSS, and is silently dropped. Every icon in the admin UI renders as raw text (more_vert, download, delete, etc.).

Proposed fix: Add a single trailing semicolon at the end of acui.css. One byte. Verified to fully restore icon rendering on our environment.

Bug 2 — Block Structure column fatals (HTTP 500) when reading legacy number_of_items value
———————————————————————————————-

In classes/Setting/ComponentFactory/GutenbergDisplay.php, add_formatters() constructs the Separator formatter via:

new AC\Formatter\Collection\Separator(
‘<br>’,
$config->get(‘number_of_items’, 20)
)

Under declare(strict_types=1), Separator::__construct() requires int $limit, but layouts that originated in v6 return this value as a string. The result is an uncaught TypeError, producing HTTP 500 on every list screen that uses a Gutenberg Blocks column in Block Structure mode. We confirmed this affects three of our saved layouts post-upgrade.

Notably, your own Separator::create_from_config() static factory does cast this value to int correctly — the cast appears to have been simply omitted at this one direct construction site, likely a copy-paste oversight.

Proposed fix: Add an (int) cast — five characters:

– $config->get(‘number_of_items’, 20)
+ (int)$config->get(‘number_of_items’, 20)

Verified on our environment that this single cast fully restores Block Structure column rendering on layouts originally saved in v6.

We are unable to ship v7 until these are fixed upstream, since modifying vendor files is not permitted in our deployment process. Could you confirm receipt and let us know whether these can be included in a 7.0.16 patch release?

Happy to provide additional details, layout exports, or stack traces as needed.

1 week, 1 day ago
Stefan van den Dungen Gronovius
Developer

Hi,

Thanks for the detailed report and proposed fixes. Both issues have been identified and fixed, and the changes will be included in the upcoming 7.0.17 release which is planned for next week.

1 week ago