Speed improvements needed for the inline editing
Currently, when an inline edit is saved, the popup of the inline edit remains open and shows a loading circle. Once the loading circle has stopped, the popup will close and the cell will appear yellow until the change is processed.
We suggest you the following : when an inline edit is saved, it’s better to close immediately the popup, so that for each inline edit we save about 5 seconds (because we have a heavy site), so we don’t have to wait for this processing, it can happen in the background we don’t have to wait for it and we can move on to the next inline edit
Also, the reason why we ask for this suggestion is that if you try to be very fast in the inline editing, your plugin is not very good to allow us be fast. Take the following example.
1 Click on “Add New Line”
2 When the line appears, click on the pen to edit the name
3 Edit the name of the product, and save
4 Immediately click on the pen to edit the price
Once the price popup will appear, the price popup will close by itself because the process running in the background for changing the product name has finished in the meantime. So it’s really annoying, we can proceed the next inline edit as long as the previous inline edit has fully completed. We lose time, especially that we have 1000 products to encode…
I guess that the speed for inline editing is dependent on the server. For example, editing a post on my environment is within milliseconds. I agree that we can ‘wait’ for the Ajax call to finish before opening a new edit modal is possible, but there is not something we can do about the speed of inline editing on your environment.
1) My server is a DigitalOcean dedicated server (hosted on Cloudways, so it’s a “managed hosting”). It’s a 16 GB RAM and 8 CPU Cores, so I believe that the server has sufficient power dedicated to make this plugin work well.
2) You said “we can ‘wait’ for the Ajax call to finish before opening a new edit modal” but I’m not sure to get what you said here. What we want is that when we click on save in the popup of an inline edit, this popup should immediately disappear (the whole processing should occur in the background), so that we can move on to the next inline edit.
So in the video here, at the second 15, you see that I click on save, but the popup needs about 5 seconds to process before disappearing. This is not ok, the popup should disappear instantly, so we can proceed to the next inline edit.
So is this possible? Thanks
Thanks for the clarification.
I understand your point, but the modal is also used for error reporting. Closing the modal before any response from the server is returned would mean that we need to skip that whole part, which we do not want to change in our plugin.
Inline editing the value in your screenshots indeed takes very long, but I want to ask you to debug this part yourself since it should not take this long at all. Our part to save a change in the Ajax call is not heavy at all, so I expect there are other plugins or functions in the WordPress startup load that will slow down any of your calls on the website.
You must be logged in to reply to this topic.